| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: REINDEX backend filtering |
| Date: | 2021-03-15 17:50:44 |
| Message-ID: | 20210315175044.txxhycqg7iaa66qy@nol |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 15, 2021 at 10:40:25AM -0700, Mark Dilger wrote:
> I'm saying that your patch seems to call down to get_collation_actual_version() via get_collation_version_for_oid() from your new function do_check_index_has_outdated_collation(), but I'm not seeing how that gets exercised.
It's a little bit late here so sorry if I'm missing something.
do_check_index_has_outdated_collation() is called from
index_has_outdated_collation() which is called from
index_has_outdated_dependency() which is called from
RelationGetIndexListFiltered(), and that function is called when passing the
OUTDATED option to REINDEX (and reindexdb --outdated). So this is exercised
with added tests for both matching and non matching collation version.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2021-03-15 17:54:47 | Re: Parser Hook |
| Previous Message | Pavel Stehule | 2021-03-15 17:41:36 | Re: Parser Hook |