Re: Nicer error when connecting to standby with hot_standby=off

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: James Coleman <jtc331(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, David Steele <david(at)pgmasters(dot)net>, David Zhang <david(dot)zhang(at)highgo(dot)ca>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Nicer error when connecting to standby with hot_standby=off
Date: 2021-03-09 14:07:35
Message-ID: 20210309140735.GA8007@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Mar-09, James Coleman wrote:

> On Tue, Mar 9, 2021 at 8:47 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> >
> > On 2021-Mar-07, Magnus Hagander wrote:
> >
> > > On Sun, Mar 7, 2021 at 3:39 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> >
> > Great, so we're agreed on the messages to emit. James, are you updating
> > your patch, considering Fujii's note about the new signal and pmstate
> > that need to be added?
>
> Perhaps I'm missing something, but I was under the impression the
> "prefer the former message" meant we were not adding a new signal and
> pmstate?

Eh, I read that differently. I was proposing two options for the DETAIL
line in that case:

> DETAIL: Hot standby mode is disabled.
> or maybe
> DETAIL: Consistent state has not yet been reached, and hot standby mode is disabled.

and both Fujii and Magnus said they prefer the first option over the
second option. I don't read any of them as saying that they would like
to do something else (including not doing anything).

Maybe I misinterpreted them?

--
Álvaro Herrera Valdivia, Chile

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message James Coleman 2021-03-09 14:11:53 Re: Nicer error when connecting to standby with hot_standby=off
Previous Message James Coleman 2021-03-09 14:03:16 Re: Nicer error when connecting to standby with hot_standby=off