| From: | 'Alvaro Herrera' <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | "k(dot)jamison(at)fujitsu(dot)com" <k(dot)jamison(at)fujitsu(dot)com> |
| Cc: | Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>, Matthieu Garrigues <matthieu(dot)garrigues(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: PATCH: Batch/pipelining support for libpq |
| Date: | 2021-03-04 00:24:29 |
| Message-ID: | 20210304002429.GA8225@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Mar-03, 'Alvaro Herrera' wrote:
> This should obviously not occur. I'm trying to figure out how to repair
> it and not break everything again ...
I think trying to set up the connection state so that the next query
appears in conn->last_query prior to PQgetResult being called again
leads to worse breakage. The simplest fix seems to make fe-protocol3.c
aware that in this case, the query is in conn->cmd_queue_head instead,
as in the attached patch.
--
Álvaro Herrera 39°49'30"S 73°17'W
| Attachment | Content-Type | Size |
|---|---|---|
| error-fix.patch | text/x-diff | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2021-03-04 00:45:02 | Re: PATCH: Batch/pipelining support for libpq |
| Previous Message | Andrew Dunstan | 2021-03-04 00:21:54 | Re: buildfarm windows checks / tap tests on windows |