Re: Add support for PROVE_FLAGS and PROVE_TESTS in MSVC scripts

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add support for PROVE_FLAGS and PROVE_TESTS in MSVC scripts
Date: 2021-03-03 10:26:19
Message-ID: 20210303102619.rjcct25dc2f42vxj@nol
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 03, 2021 at 05:19:22PM +0900, Michael Paquier wrote:
>
> Each time I do development on Windows, I get annoyed by the fact that
> it is not easy to run individual test scripts in the same way as we do
> on any other platforms, using PROVE_TESTS, or even PROVE_FLAGS. And
> there have been recent complaints about not being able to do that.
>
> Please find attached a patch to support both variables, with some
> documentation. Using a terminal on Windows, one can set those
> variables using just.. "set", say:
> set PROVE_FLAGS=--timer
> set PROVE_TESTS=t/020*.pl t/010*.pl
>
> Note the absence of quotes for the second one, so as it is possible to
> apply cleanly glob() to each element passed down.
>
> Thoughts?

+1, I heavily rely on that and I can imagine how hard it's to develop a patch
on windows without it.

Patch LGTM, althouth I don't have any Windows environnment to test it.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message houzj.fnst@fujitsu.com 2021-03-03 10:30:55 Avoid CommandCounterIncrement in RI trigger when INSERT INTO referencing table
Previous Message Julien Rouhaud 2021-03-03 09:52:10 Re: Increase value of OUTER_VAR