Re: Extensions not dumped when --schema is used

On Thu, Feb 18, 2021 at 11:13:06AM +0100, Guillaume Lelarge wrote:
> Le mar. 26 janv. 2021 à 13:42, Guillaume Lelarge <guillaume(at)lelarge(dot)info> a
> écrit :
>
> > Le mar. 26 janv. 2021 à 13:41, Guillaume Lelarge <guillaume(at)lelarge(dot)info>
> > a écrit :
> >
> >> Le mar. 26 janv. 2021 à 05:10, Julien Rouhaud <rjuju123(at)gmail(dot)com> a
> >> écrit :
> >>
> >>> On Mon, Jan 25, 2021 at 9:34 PM Guillaume Lelarge
> >>> <guillaume(at)lelarge(dot)info> wrote:
> >>> >
> >>> > "Anytime soon" was a long long time ago, and I eventually completely
> >>> forgot this, sorry. As nobody worked on it yet, I took a shot at it. See
> >>> attached patch.
> >>>
> >>> Great!
> >>>
> >>> I didn't reviewed it thoroughly yet, but after a quick look it sounds
> >>> sensible. I'd prefer to see some tests added, and it looks like a
> >>> test for plpgsql could be added quite easily.
> >>>
> >>>
> >> I tried that all afternoon yesterday, but failed to do so. My had still
> >> hurts, but I'll try again though it may take some time.
> >>
> >>
> > s/My had/My head/ ..
> >
> >
> I finally managed to get a working TAP test for my patch. I have no idea if
> it's good, and if it's enough. Anyway, new version of the patch attached.
>
>
> --
> Guillaume.

Thanks for doing this work!

> diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml
> index bcbb7a25fb..95d45fabfb 100644
> --- a/doc/src/sgml/ref/pg_dump.sgml
> +++ b/doc/src/sgml/ref/pg_dump.sgml
> @@ -215,6 +215,38 @@ PostgreSQL documentation
> </listitem>
> </varlistentry>
>
> + <varlistentry>
> + <term><option>-e <replaceable class="parameter">pattern</replaceable></option></term>
> + <term><option>--extension=<replaceable class="parameter">pattern</replaceable></option></term>
> + <listitem>
> + <para>
> + Dump only extensions matching <replaceable
> + class="parameter">pattern</replaceable>. When this option is not
> + specified, all non-system extensions in the target database will be
> + dumped. Multiple schemas can be selected by writing multiple
^^^^^^^^^^^^^^^^
I think this should read "Multiple extensions".

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate