| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: Snapbuild woes followup |
| Date: | 2021-02-16 01:12:51 |
| Message-ID: | 20210216011251.nhyjwc5k3kxqtz5p@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2021-01-29 14:04:47 +0530, Amit Kapila wrote:
> On Tue, Jan 26, 2021 at 2:18 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> >
> > Hi,
> >
> > On 2021-01-25 12:00:08 -0800, Andres Freund wrote:
> > > > > /*
> > > > > * For backward compatibility reasons this has to be stored in the wrongly
> > > > > * named field. Will be fixed in next major version.
> > > > > */
> > > > > return builder->was_running.was_xmax;
> > > >
> > > > We could fix that now... Andres, what did you have in mind for a proper
> > > > name?
> > >
> > > next_phase_at seems like it'd do the trick?
> >
>
> The new proposed name sounds good to me.
And pushed.
> > See attached patch...
>
> LGTM.
Thanks for looking over - should have added your name to reviewed-by,
sorry...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2021-02-16 01:19:27 | Re: PATCH: Batch/pipelining support for libpq |
| Previous Message | Michael Paquier | 2021-02-16 00:51:38 | Re: pg_replication_origin_session_setup and superuser |