Re: pg_wal_lsn_diff

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us
Cc: pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: pg_wal_lsn_diff
Date: 2021-02-07 01:57:01
Message-ID: 20210207.105701.515450239500106923.t-ishii@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

> +1 for fixing that. Two notes though: first, your text doesn't agree
> with the prototype ("ls1" should be "lsn1"), and second, I think it
> would read better if you didn't split the phrase "difference in bytes".
> That is,
>
> - Calculates the difference in bytes between two write-ahead log
> + Calculates the difference in bytes (lsn1 - lsn2) between two write-ahead log
>
> Also maybe you should use the <parameter>lsn1</parameter> markup
> in the text.

Thank you for the review. Attached is the revised patch.

So do you think we should back-patch to existing stable branches? The
reason I am asking is, the doc format for v12 and before use very
simple description and if we apply the same description of this patch
to those branche, the description level for the function may look
different from other functions.

(I am not against to apply to v13).

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

Attachment Content-Type Size
pg_wal_lsn_diff-v2.diff text/x-patch 1.1 KB

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Tom Lane 2021-02-07 02:16:56 Re: pg_wal_lsn_diff
Previous Message Tom Lane 2021-02-06 20:48:26 Re: The synopsis of "ALTER DEFAULT PRIVILEGES" statement is too difficult to understand