Re: Odd, intermittent failure in contrib/pageinspect

From: Andres Freund <andres(at)anarazel(dot)de>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Odd, intermittent failure in contrib/pageinspect
Date: 2021-01-20 01:50:06
Message-ID: 20210120015006.xbw5ol7va66warlu@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2021-01-18 19:40:05 -0300, Alvaro Herrera wrote:
> > [ thinks for a bit... ] Does the checkpointer pin pages it's writing
> > out? I guess it'd have to ...
>
> It does, per SyncOneBuffer(), called from BufferSync(), called from
> CheckPointBuffers().

I think you don't event need checkpointer to be involved, normal buffer
replacement would do the trick. We briefly pin the page in BufferAlloc()
even if the page is clean. Longer when it's dirty, of course.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-01-20 01:57:22 Re: Odd, intermittent failure in contrib/pageinspect
Previous Message Tom Lane 2021-01-20 01:37:08 Re: [PATCH 1/1] Fix detection of pwritev support for OSX.