Re: Add Information during standby recovery conflicts

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: masao(dot)fujii(at)oss(dot)nttdata(dot)com
Cc: bdrouvot(at)amazon(dot)com, sawada(dot)mshk(at)gmail(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, masahiko(dot)sawada(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add Information during standby recovery conflicts
Date: 2021-01-08 02:17:12
Message-ID: 20210108.111712.1465719681094712823.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Fri, 8 Jan 2021 01:32:11 +0900, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote in
>
> Attached is the updated version of the patch. This can be applied to
> current master.
>
> With the patch, for example, if the startup process waited longer than
> deadlock_timeout for the recovery conflict on the lock, the latter log
> message in the followings would be additionally output.
>
> LOG: recovery still waiting after 1001.223 ms: recovery conflict on
> lock
> LOG: recovery finished waiting after 19004.694 ms: recovery conflict
> on lock

+ /*
+ * Emit the log message if recovery conflict on buffer pin was resolved but
+ * the startup process waited longer than deadlock_timeout for it.

The first line is beyond the 80th column.

LGTM other than the above.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-01-08 02:29:53 Re: Incorrect allocation handling for cryptohash functions with OpenSSL
Previous Message Hou, Zhijie 2021-01-08 02:02:40 RE: Single transaction in the tablesync worker?