| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add pg_alterckey utility to change the cluster key |
| Date: | 2020-12-26 03:40:37 |
| Message-ID: | 20201226034037.GG19054@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Dec 25, 2020 at 10:36:55PM -0500, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Add pg_alterckey utility to change the cluster key
>
> > Modified Files
> > --------------
> > doc/src/sgml/ref/pg_alterkey.sgml | 186 ++++++++++
>
> 1. I wonder why this file is "pg_alterkey.sgml" when the
> program it documents is pg_alterckey.
Oh, mistake then, will fix.
>
> 2. Regardless of name, this file is dead code because you did not
> hook it into the documentation infrastructure.
Wow, another issue.
> 3. The buildfarm says this commit is (still) busted on Win32.
>
> Possibly these commits need more review than you think.
I am fixing those now. It is a sleep() and ifdef-inside-macro problem.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2020-12-26 03:47:28 | pgsql: pg_alterckey: adjust doc build and Win32 sleep/open build fails |
| Previous Message | Tom Lane | 2020-12-26 03:36:55 | Re: pgsql: Add pg_alterckey utility to change the cluster key |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-12-26 03:49:58 | Re: pgsql: Add pg_alterckey utility to change the cluster key |
| Previous Message | Tom Lane | 2020-12-26 03:36:55 | Re: pgsql: Add pg_alterckey utility to change the cluster key |