Re: pgsql: Add key management system

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add key management system
Date: 2020-12-25 19:09:35
Message-ID: 20201225190935.GY30237@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

I think cipher_failure() should be marked pg_attribute_noreturn().

gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -O2 -I./src/include -D_GNU_SOURCE -I/usr/include/libxml2 -c -o src/common/cipher.o src/common/cipher.c
src/common/cipher.c: In function ‘pg_cipher_ctx_create’:
src/common/cipher.c:28:1: warning: control reaches end of non-void function [-Wreturn-type]
28 | }

--
Justin

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-12-25 19:17:10 Re: pgsql: Add key management system
Previous Message Noah Misch 2020-12-25 19:07:05 pgsql: Fix back-patch of "Invalidate acl.c caches when pg_authid change

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-12-25 19:17:10 Re: pgsql: Add key management system
Previous Message Bruce Momjian 2020-12-25 19:01:06 Re: pgsql: Add key management system