Re: [PATCH] fix compilation with gnu89

From: Andres Freund <andres(at)anarazel(dot)de>
To: Rosen Penev <rosenp(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] fix compilation with gnu89
Date: 2020-11-30 04:49:44
Message-ID: 20201130044944.y2tavdr52hk4g36d@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2020-11-29 20:33:41 -0800, Rosen Penev wrote:
> GCC 4.8.5 does not default to gnu99 or gnu11 like the newer versions.

We require C99 support since postgres 12, and configure should end up
choosing flags to make the compiler support that if possible.

As far as I can tell the code you changed doesn't actually exist in <=
11, so I don't see what problem it'd fix. And for newer branches you'd
obviously need a lot more changes than just this...

Regards,

Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-11-30 04:50:42 Re: [PATCH] fix compilation with gnu89
Previous Message Tom Lane 2020-11-30 04:44:38 Re: Improving spin-lock implementation on ARM.