Re: pgsql: Move per-agg and per-trans duplicate finding to the planner.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Move per-agg and per-trans duplicate finding to the planner.
Date: 2020-11-24 10:58:53
Message-ID: 20201124105853.GH3046@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi Heikki,

On Tue, Nov 24, 2020 at 08:53:42AM +0000, Heikki Linnakangas wrote:
> Move per-agg and per-trans duplicate finding to the planner.
>
> This has the advantage that the cost estimates for aggregates can count
> the number of calls to transition and final functions correctly.
>
> Bump catalog version, because views can contain Aggrefs.
>
> Reviewed-by: Andres Freund
> Discussion: https://www.postgresql.org/message-id/b2e3536b-1dbc-8303-c97e-89cb0b4a9a48%40iki.fi

The regression tests of sepgsql are broken:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rhinoceros&dt=2020-11-24%2009%3A52%3A17

Reordering the lines in the output file would fix the issue.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2020-11-24 11:40:40 Re: pgsql: Move per-agg and per-trans duplicate finding to the planner.
Previous Message Heikki Linnakangas 2020-11-24 08:53:42 pgsql: Move per-agg and per-trans duplicate finding to the planner.