Re: pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
Date: 2020-11-16 17:36:32
Message-ID: 20201116173632.GD22426@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Nov 12, 2020 at 06:15:51PM -0500, Bruce Momjian wrote:
> On Thu, Nov 12, 2020 at 05:29:00PM -0300, Álvaro Herrera wrote:
> > On 2020-Nov-12, Bruce Momjian wrote:
> >
> > > doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
> > >
> > > These files are in compiled directories and install directories.
> >
> > I think this patch is wrong, because in the install tree the files are in
> > the server/ subdir. It should read:
> >
> > The <acronym>OID</acronym>s of the built-in data types are defined in
> > the file <filename>include/catalog/pg_type_d.h</filename> in the
> > compiled source directory, and in
> > <filename>include/server/catalog/pg_type_d.h</filename> in the install
> > directory.
> >
> > That said, if the user is doing a VPATH build, then "compiled source
> > directory" is a confusing way to say "the build directory", and I don't
> > think it's an important location anyway, first because it's really a
> > throwaway directory, and second it's not even there in a packaged
> > installation; users just care about the *installed* file, don't they?
> > So I suggest to rip that part out, and leave just:
> >
> > The <acronym>OID</acronym>s of the built-in data types are defined in
> > the file <filename>include/server/catalog/pg_type_d.h</filename> in the
> > install directory.
>
> OK, how is this followup patch?

Applied to all branches, thanks.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2020-11-16 17:36:35 pgsql: doc: clarify how to find pg_type_d.h in the install tree
Previous Message Peter Eisentraut 2020-11-16 16:30:43 pgsql: Remove unused and deprecated strategy numbers from BRIN code