Re: pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
Date: 2020-11-12 20:29:00
Message-ID: 20201112202900.GA28098@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2020-Nov-12, Bruce Momjian wrote:

> doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
>
> These files are in compiled directories and install directories.

I think this patch is wrong, because in the install tree the files are in
the server/ subdir. It should read:

The <acronym>OID</acronym>s of the built-in data types are defined in
the file <filename>include/catalog/pg_type_d.h</filename> in the
compiled source directory, and in
<filename>include/server/catalog/pg_type_d.h</filename> in the install
directory.

That said, if the user is doing a VPATH build, then "compiled source
directory" is a confusing way to say "the build directory", and I don't
think it's an important location anyway, first because it's really a
throwaway directory, and second it's not even there in a packaged
installation; users just care about the *installed* file, don't they?
So I suggest to rip that part out, and leave just:

The <acronym>OID</acronym>s of the built-in data types are defined in
the file <filename>include/server/catalog/pg_type_d.h</filename> in the
install directory.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Erik Rijkers 2020-11-12 20:29:20 Re: pgsql: docs: mention that expression indexes need analyze
Previous Message Bruce Momjian 2020-11-12 20:13:20 pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h