| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Use the non-deprecated TG_TABLE_MAME in test trigger |
| Date: | 2020-11-07 01:26:06 |
| Message-ID: | 20201107012606.GC3528@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hi Magnus,
On Tue, Nov 03, 2020 at 09:22:40AM +0000, Magnus Hagander wrote:
> Use the non-deprecated TG_TABLE_MAME in test trigger
>
> Commit 3a9ae3d2068 (back in 2006) deprecated TG_RELNAME
> in favor of TG_TABLE_NAME, but the existing usage in test
> cases has remained till today. Change to use TG_TABLE_NAME
> instead (TG_RELNAME is still covered by a test case).
I think that you should be careful to add the "Discussion:" tag in the
commit message. These are really useful to keep track of the
thread(s) where a specific problem was discussed (applies as well to
13cfa02, 5d1833f, and other commits done the same day).
Thanks,
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-11-07 01:46:30 | pgsql: Add GUC_LIST_INPUT and GUC_LIST_QUOTE to unix_socket_directories |
| Previous Message | Michael Paquier | 2020-11-07 01:23:13 | pgsql: Fix minor issues with new unicode {de,re}composition code |