Re: hash_array_extended() needs to pass down collation

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: hash_array_extended() needs to pass down collation
Date: 2020-11-03 10:48:54
Message-ID: 20201103104854.GE2298@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 02, 2020 at 10:01:53AM -0500, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>> I noticed that hash_array_extended() does not pass down the collation to
>> the element's collation function, unlike hash_array(). As a
>> consequence, hash partitioning using text arrays as partition key fails.
>
>> The attached patch fixes this. I propose to backpatch this.
>
> LGTM

+1.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Borisov 2020-11-03 10:53:12 Re: Bogus documentation for bogus geometric operators
Previous Message Michael Paquier 2020-11-03 10:35:18 Re: Move OpenSSL random under USE_OPENSSL_RANDOM