Re: Consistent error reporting for encryption/decryption in pgcrypto

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Consistent error reporting for encryption/decryption in pgcrypto
Date: 2020-10-30 00:31:32
Message-ID: 20201030003132.GA1693@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 29, 2020 at 10:26:54PM +0100, Daniel Gustafsson wrote:
> The attached introduce PXE_ENCRYPT_FAILED and use that for EVP_EncryptUpdate to
> ideally be slightly clearer in case of errors. Any reason not to do that
> instead of using ERR_GENERIC?

+1. While looking at that, I was wondering of the potential need of
this error code for other encryption code paths, but it happens that
this is only specific to OpenSSL. Rijndael or Blowfish don't need
it.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2020-10-30 00:32:40 Re: Deleting older versions in unique indexes to avoid page splits
Previous Message Peter Geoghegan 2020-10-29 23:48:37 Re: Deleting older versions in unique indexes to avoid page splits