Re: Online checksums verification in the backend

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: "Shinoda, Noriyoshi (PN Japan A&PS Delivery)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Subject: Re: Online checksums verification in the backend
Date: 2020-10-29 00:39:42
Message-ID: 20201029003942.GA6118@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 29, 2020 at 08:12:42AM +0800, Julien Rouhaud wrote:
> As far as I can see the issue is that the pfree(path) in
> check_relation_fork() should be outside the for loop.

Yes, this would be triggered if more than one page is found as broken
in a single SRF. Fixed, thanks Shinoda-san.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2020-10-29 00:48:46 Re: [HACKERS] logical decoding of two-phase transactions
Previous Message Tom Lane 2020-10-29 00:20:09 Re: pg_prewarm bgworker could break fast shutdown