Re: pgsql: Extend PageIsVerified() to handle more custom options

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Extend PageIsVerified() to handle more custom options
Date: 2020-10-26 14:39:33
Message-ID: 20201026143933.GA5304@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2020-Oct-26, Michael Paquier wrote:

> Extend PageIsVerified() to handle more custom options
>
> This is useful for checks of relation pages without having to load the
> pages into the shared buffers, and two cases can make use of that: page
> verification in base backups and the online, lock-safe, flavor.
>
> Compatibility is kept with past versions using a macro that calls the
> new extended routine with the set of options compatible with the
> original version.

Please remember that in the macro definition, the arguments should be
enclosed in parens. No bug here at present, but it seems better to be
cautious.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-10-26 15:37:08 pgsql: In INSERT/UPDATE, use the table's real tuple descriptor as targe
Previous Message Heikki Linnakangas 2020-10-26 07:16:05 pgsql: docs: Remove notes about incompatibilies with very old versions.