| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)2ndquadrant(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, andres(at)anarazel(dot)de, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, amit(dot)kapila16(at)gmail(dot)com |
| Subject: | Re: Enumize logical replication message actions |
| Date: | 2020-10-23 01:31:41 |
| Message-ID: | 20201023013141.GA8393@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Oct-22, Ashutosh Bapat wrote:
> On Thu, 22 Oct 2020 at 14:46, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
> wrote:
> > pg_send_logicalrep_msg_type() looks somewhat too-much. If we need
> > something like that we shouldn't do this refactoring, I think.
>
> Enum is an integer, and we want to send byte. The function asserts that the
> enum fits a byte. If there's a way to declare byte long enums I would use
> that. But I didn't find a way to do that.
I didn't look at the code, but maybe it's sufficient to add a
StaticAssert?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andy Fan | 2020-10-23 01:31:57 | Would it be helpful for share the patch merge result from cfbot |
| Previous Message | Kyotaro Horiguchi | 2020-10-23 01:20:11 | Re: Enumize logical replication message actions |