Re: BUG #16577: Segfault on altering a table located in a dropped tablespace

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #16577: Segfault on altering a table located in a dropped tablespace
Date: 2020-10-15 15:19:59
Message-ID: 20201015151959.GA6823@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 2020-Sep-09, Tomas Vondra wrote:

> On Tue, Sep 08, 2020 at 06:37:29PM -0300, Alvaro Herrera wrote:
> > On 2020-Sep-08, Michael Paquier wrote:
> >
> > > On Tue, Aug 11, 2020 at 04:04:07PM +0900, Michael Paquier wrote:
> > > > Hmm. Creating a file for partitioned table would be a completely new
> > > > thing as well. heap_create() has never created a file for partitioned
> > > > tables since 10 so this could open to a new class of bugs.
> > >
> > > This thread has stalled for a couple of weeks now, and I would tend to
> > > take the path where we'd basically revert 8725958 and ca41030. That's
> > > too late for v13 to do anything about that. But not for 14. Any
> > > opinions?
> >
> > Well, naturally I oppose this idea.
>
> Would it actually solve the issue? ISTM we'd still have to expect cases
> with partitioned tables without storage, so presumably we'd have to do
> something else ...

It just dawned on me that a way to fix this is to use a pg_shdepend
entry to protect the tablespace from being dropped.

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Bruce Momjian 2020-10-15 16:46:38 Re: BUG #16672: Postgres user passwords are corrupted during migration
Previous Message Alvaro Herrera 2020-10-15 15:15:57 Re: Bugreport | Logical replication PostgreSQL 12 | Error after disable / enable replication