| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Brar Piening <brar(at)gmx(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Minor documentation error regarding streaming replication protocol |
| Date: | 2020-10-15 02:25:38 |
| Message-ID: | 20201015022538.GA3797@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 14, 2020 at 05:10:30PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Patch attached. I would like to backpatch this to all supported
> > versions so we are consistent and people don't think different PG
> > versions use different return values for this. Is that safe? Looking
> > at the uses of this in our code, it seems so. We aren't doing BYTEA
> > escaping or TEXT encoding conversion in any of these cases.
>
> I do not think a back-patch is a good idea. Yeah, it probably
> won't break anything, but by the same token it won't fix anything.
OK, I can instead put in a C comment that it is really TEXT like the
other fields, but update the docs in all branches. Does that work for
everyone?
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2020-10-15 02:44:43 | Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump. |
| Previous Message | Fujii Masao | 2020-10-15 02:12:10 | Re: Add a description to the documentation that toast_tuple_target affects "Main" |