| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | alvherre(at)alvh(dot)no-ip(dot)org, iwata(dot)aya(at)fujitsu(dot)com, pgsql-hackers(at)postgresql(dot)org, tgl(at)sss(dot)pgh(dot)pa(dot)us, robertmhaas(at)gmail(dot)com, pchampion(at)pivotal(dot)io, jdoty(at)pivotal(dot)io, raam(dot)soft(at)gmail(dot)com, nagaura(dot)ryohei(at)fujitsu(dot)com, nagata(at)sraoss(dot)co(dot)jp, peter(dot)eisentraut(at)2ndquadrant(dot)com, horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp, k(dot)jamison(at)fujitsu(dot)com |
| Subject: | Re: libpq debug log |
| Date: | 2020-10-14 05:18:20 |
| Message-ID: | 20201014051820.GF3349@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 14, 2020 at 10:18:38AM +0900, Kyotaro Horiguchi wrote:
> At Fri, 9 Oct 2020 11:48:59 -0300, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote in
>> Doesn't enlargePQExpBuffer() include room for the trailing zero? I
>> think it does.
>
> Right. I faintly recall I said the same thing before..
FWIW, as pqexpbuffer.c says, it does:
needed += str->len + 1; /* total space required now */
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2020-10-14 05:22:33 | Re: More efficient RI checks - take 2 |
| Previous Message | Michael Paquier | 2020-10-14 05:06:47 | Re: Two fsync related performance issues? |