From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Brar Piening <brar(at)gmx(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Minor documentation error regarding streaming replication protocol |
Date: | 2020-10-08 23:52:50 |
Message-ID: | 20201008235250.GA1528@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Oct 08, 2020 at 04:23:06PM -0400, Bruce Momjian wrote:
> I have looked at this. It seems SendTimeLineHistory() is sending raw
> bytes from the history file, with no encoding conversion, and
> ReceiveXlogStream() is receiving it, again assuming it is just plain
> text. I am not sure we really have an SQL data type where we do this.
> BYTEA doesn't do encoding conversion, but does backslash procesing, and
> TEXT does encoding conversion.
>
> I suppose we either have to document this as BYTEA with no backslash
> processing, or TEXT with no encoding conversion --- I think I prefer the
> later.
As StartupXLOG() tells, The timeline history file can include as
reason the recovery target name which may not be made just of ASCII
characters as that's the value specified in pg_create_restore_point by
the user, so bytea is correct, no?
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-10-08 23:59:15 | Re: Assertion failure with LEFT JOINs among >500 relations |
Previous Message | David Rowley | 2020-10-08 23:27:21 | Re: Assertion failure with LEFT JOINs among >500 relations |