Re: [PATCH] ecpg: fix progname memory leak

On Thu, Oct 8, 2020 at 10:13:53AM -0700, John W Higgins wrote:
>
> On Wed, Oct 7, 2020 at 6:35 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Oct 07, 2020 at 02:31:54PM +0300, Maksim Kita wrote:
> > Fix progname memory leak in ecpg client.
> > Issue taken from todo list https://wiki.postgresql.org/wiki/Todo.
>
> FWIW, I don't see much point in doing that.  
>
>
> I hope that everyone takes 10 seconds and realizes that this appears to be this
> person's first submitted patch. I would think a little more respect for the
> attempt to patch a minor issue would be afforded to such a person. Seems
> technically sound and they are not trying to change the world with their first
> attempt. 
>
> Maybe a reminder that the TODO list is not always spectacular and that a double
> check with the list before doing something might be in order (in fact adding
> that to the top of the TODO list might be a great option here as well).
>
> It's not going to win a Turing award - but I thought this project was a little
> more friendly then what I've seen in this thread towards a first time
> contributor.

You mean like the warning at the top of the TODO list?

https://wiki.postgresql.org/wiki/Todo#Development_Process

WARNING for Developers: Unfortunately this list does not contain all the
information necessary for someone to start coding a feature. Some of
these items might have become unnecessary since they were added ---
others might be desirable but the implementation might be unclear. When
selecting items listed below, be prepared to first discuss the value of
the feature. Do not assume that you can select one, code it and then
expect it to be committed. Always discuss design on Hackers list before
starting to code. The flow should be:

Desirability -> Design -> Implement -> Test -> Review -> Commit

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee