| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Probably typo in multixact.c |
| Date: | 2020-10-08 16:42:28 |
| Message-ID: | 20201008164228.GC13054@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 8, 2020 at 10:26:39AM +0900, Michael Paquier wrote:
> On Thu, Oct 08, 2020 at 01:15:35AM +0000, Hou, Zhijie wrote:
> > Hi
> >
> > In multixact.c I found some comments like the following:
> >
> > * Similar to AtEOX_MultiXact but for COMMIT PREPARED
> > * Discard the local MultiXactId cache like in AtEOX_MultiXact
> >
> > Since there's no function called "AtEOX_MultiXact" in the code,
> > I think the "AtEOX_MultiXact" may be a typo.
> >
> > AtEOXact_MultiXact seems to be the right function here.
>
> Yes, that looks like a simple typo to me as well.
> AtEOXact_MultiXact() shares portions of the logics in
> PostPrepare_MultiXact and multixact_twophase_postcommit.
FYI, this patch was applied.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Meskes | 2020-10-08 16:58:14 | Re: [PATCH] ecpg: fix progname memory leak |
| Previous Message | Bruce Momjian | 2020-10-08 16:27:11 | Re: [PATCH] ecpg: fix progname memory leak |