Re: [PATCH] ecpg: fix progname memory leak

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Maksim Kita <kitaetoya(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] ecpg: fix progname memory leak
Date: 2020-10-08 01:35:41
Message-ID: 20201008013541.GB3457@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 07, 2020 at 02:31:54PM +0300, Maksim Kita wrote:
> Fix progname memory leak in ecpg client.
> Issue taken from todo list https://wiki.postgresql.org/wiki/Todo.

FWIW, I don't see much point in doing that. For one, we have a
more-or-less established rule that progname remains set until the
application leaves, and there are much more places where we leak
memory like that. As one example, just see the various places where
we use pg_strdup for option parsing. At the end, it does not really
matter as these are applications running for a short amount of time.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2020-10-08 01:42:00 Re: new heapcheck contrib module
Previous Message Andy Fan 2020-10-08 01:34:51 Re: [PATCH] Keeps tracking the uniqueness with UniqueKey