Re: pgsql: Fix race in test of pg_switch_wal().

From: Noah Misch <noah(at)leadboat(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix race in test of pg_switch_wal().
Date: 2020-10-07 02:03:27
Message-ID: 20201007020327.GC1422897@rfd.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, Sep 14, 2020 at 05:27:07PM +0900, Michael Paquier wrote:
> On Mon, Sep 14, 2020 at 06:19:38AM +0000, Noah Misch wrote:
> > Fix race in test of pg_switch_wal().
> >
> > The test failed when something added WAL between pg_switch_wal() and
> > pg_current_wal_lsn(), seen on buildfarm members hornet and sungazer.
> > Fix v10, v9.6 and v9.5 by making this code mirror its v13+ counterpart.
> > v12 and v11 lack a counterpart.
>
> Thanks Noah for that, I did not notice those buildfarm failures:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hornet&dt=2020-07-24%2010%3A24%3A56
>
> It is fine to ping me or just to begin a thread if there is a problem,
> I would have taken care of it.

There's a new 020_archive_status.pl failure:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mandrill&dt=2020-10-05%2023%3A02%3A17

Would you like to diagnose/fix that one?

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2020-10-07 02:13:47 Re: pgsql: postgres_fdw: reestablish new connection if cached one is detect
Previous Message Bruce Momjian 2020-10-06 18:35:58 pgsql: pg_upgrade: remove pre-8.4 code and >= 8.4 check