From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, R Ransbottom <rirans(at)comcast(dot)net>, Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Pg Docs <pgsql-docs(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Documentation: 21.5. Default Roles |
Date: | 2020-10-05 20:31:12 |
Message-ID: | 20201005203112.GD4993@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs |
On Tue, Apr 28, 2020 at 04:02:25PM -0400, Jonathan Katz wrote:
> On 4/28/20 2:19 PM, Magnus Hagander wrote:
> > On Sat, Apr 25, 2020 at 1:38 AM Jonathan S. Katz <jkatz(at)postgresql(dot)org
> > <mailto:jkatz(at)postgresql(dot)org>> wrote:
> >
> > On 4/9/20 11:45 PM, Bruce Momjian wrote:
> > > On Thu, Apr 9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote:
> > >> On 4/9/20 4:57 PM, Bruce Momjian wrote:
> > >>> Jonathan, Stephen, with the minor release done, can we focus on
> > adding
> > >>> the URL redirect and completing the patch to rename this feature
> > in the
> > >>> docs? Thanks.
> > >>
> > >> Yes, I have a prototype for this ready, which I had scrambled
> > together
> > >> before the release. I am happy to make it committable in the
> > coming days.
> > >
> > > Thanks. Once that is done Stephen can apply my patch with his
> > > additions.
> >
> > Please see attached patch for pgweb that allows for the documentation to
> > be redirected from a page that is removed to a newer page. The way
> > it works:
> >
> > - Checks to see if a page is found. If it is, great!
> > - Now if a page 404s, we first check to see if there is a forwarding
> > address, i.e. the new page. If it is, we issue a 301 (permanent
> > redirecTt).
> > - If it's still not found, we abort.
> >
> > I believe this gives us the desired behavior.
> >
> > Thoughts on the patch?
> >
> >
> > Looks good to me. Go for it.
>
> This is deployed. Ready for the patch in core.
OK, Stephen, I believe you have a more comprehensive patch to make this
change. When can you complete it? The above email is from April.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2020-10-06 11:58:05 | Re: Installation instructions vs binaries |
Previous Message | Bruce Momjian | 2020-10-05 20:28:28 | Re: Please provide examples of rows from |