| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: A modest proposal: let's add PID to assertion failure messages |
| Date: | 2020-10-05 00:58:24 |
| Message-ID: | 20201005005824.GG1464@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 05, 2020 at 10:20:01AM +1300, Thomas Munro wrote:
> On Mon, Oct 5, 2020 at 10:08 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> In these days when we run almost all test cases in parallel, it's
>> frequently not that easy to tie a "TRAP: ..." message in the log
>> to nearby log messages. (The postmaster's subsequent complaint
>> often helps, but it could be some distance away in the log; and
>> good luck untangling things if more than one Assert failure happens
>> concurrently.) We could add a simple bread crumb trail by
>> including the process's PID in such messages. Any objections?
>
> +1
+1. (log_line_prefix includes %p in its default configuration for the
TAP tests).
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-10-05 01:05:54 | Re: Add header support to text format and matching feature |
| Previous Message | Michael Paquier | 2020-10-05 00:48:21 | Re: Buggy handling of redundant options in COPY |