| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nagaraj Raj <nagaraj(dot)sf(at)yahoo(dot)com>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: ERROR: insufficient columns in the PRIMARY KEY constraint definition |
| Date: | 2020-09-29 23:22:25 |
| Message-ID: | 20200929232225.GA16296@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 2020-Sep-30, David Rowley wrote:
> I didn't go with the same wording. The reason was that I didn't feel
> the word "constraint" had to be mentioned twice.
>
> I won't object if you or Alvaro want to keep Alvaro's suggestion though.
*Shrug* this seems good enough. A purist could complain that it is
redundant, but in practice it's not important.
Here's the proposed error message fix, using the wording that saves
$1.99. I agree that trying to cram the constraint type in the primary
message is uglier.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Reword-error-message.patch | text/x-diff | 5.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2020-09-29 23:53:49 | Re: ERROR: insufficient columns in the PRIMARY KEY constraint definition |
| Previous Message | Tom Lane | 2020-09-29 23:21:30 | Re: ERROR: insufficient columns in the PRIMARY KEY constraint definition |