| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: AppendStringInfoChar instead of appendStringInfoString |
| Date: | 2020-09-27 18:37:52 |
| Message-ID: | 20200927183751.GA8476@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 25, 2020 at 08:49:57AM +0000, Hou, Zhijie wrote:
> In (/src/backend/replication/backup_manifest.c)
>
> I found the following code:
>
> appendStringInfoString(&buf, "\n");
> appendStringInfoString(&buf, "\"");
Good point. There's another one:
$ git grep -E 'appendStringInfoString.*".{,1}");'
src/backend/utils/adt/ruleutils.c: appendStringInfoString(buf, "(");
I noticed you added a similar thread here.
https://commitfest.postgresql.org/30/
I think this one could be combined as a single patchset with the existing CF
entry for the other thread.
https://www.postgresql.org/message-id/flat/cb172cf4361e4c7ba7167429070979d4%40G08CNEXMBPEKD05.g08.fujitsu.local
https://www.postgresql.org/message-id/ce9a8564ccf1435eacf14bb7364ae9de%40G08CNEXMBPEKD05.g08.fujitsu.local
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andy Fan | 2020-09-27 19:59:10 | Partition prune with stable Expr |
| Previous Message | Tom Lane | 2020-09-27 17:06:13 | Re: Fwd: Extending range type operators to cope with elements |