| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Allow ERROR from heap_prepare_freeze_tuple to be downgraded to WARNING |
| Date: | 2020-09-14 19:00:18 |
| Message-ID: | 20200914190018.GA22824@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Sep-14, Andres Freund wrote:
> It seems pretty dangerous to me. What exactly are you going to put into
> xmin/xmax here? And how would anything you put into the first tuple not
> break index lookups? There's no such thing as a frozen xmax (so far), so
> what are you going to put in there? A random different xid?
> FrozenTransactionId? HEAP_XMAX_INVALID?
>
> This whole approach just seems likely to exascerbate corruption while
> also making it impossible to debug. That's ok enough if it's an explicit
> user action, but doing it based on a config variable setting seems
> absurdly dangerous to me.
FWIW I agree with Andres' stance on this. The current system is *very*
complicated and bugs are obscure already. If we hide them, what we'll
be getting is a system where data can become corrupted for no apparent
reason.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-09-14 19:26:04 | Re: pg_restore causing deadlocks on partitioned tables |
| Previous Message | Ranier Vilela | 2020-09-14 18:53:48 | Re: Since '2001-09-09 01:46:40'::timestamp microseconds are lost when extracting epoch |