| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | btkatsuragiyu <btkatsuragiyu(at)oss(dot)nttdata(dot)com>, pgsql-docs(at)postgresql(dot)org |
| Subject: | Re: Fix the example in the document of file-fdw |
| Date: | 2020-09-14 05:07:16 |
| Message-ID: | 20200914050716.GC2183@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
On Mon, Sep 14, 2020 at 11:33:23AM +0900, Fujii Masao wrote:
> On 2020/09/14 11:19, btkatsuragiyu wrote:
>> Although csvlog has the leader_pid field, the document of file-fdw
>> that uses csvlog as an example does not reflect this fact.
>> Concretely, the DDL for table definition does not have the leader_pid field.
>
> This seems an oversight of commit b8fdee7d0c.
Dammit, I thought that I had all the places for that stuff done. The
patch looks fine to me.
>> This patch fixes the DDL in the document of file-fdw.
>
> Thanks for the patch! LGTM. I will commit it.
Hmm. Instead of keeping a copy-paste of the same table in both
config.sgml and file-fdw.sgml, why not having only one? It seems to
me that we could just have the file_fdw doc refer to the main
configuration, and it is not difficult to guess how the CREATE TABLE
query needs to be changed to map with foreign table.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | btkatsuragiyu | 2020-09-14 07:10:03 | Re: Fix the example in the document of file-fdw |
| Previous Message | Fujii Masao | 2020-09-14 02:33:23 | Re: Fix the example in the document of file-fdw |