From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Weird corner-case failure mode for VPATH builds |
Date: | 2020-09-11 18:13:58 |
Message-ID: | 20200911181358.jzo57wz4iboyxpwe@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2020-09-11 13:58:41 -0300, Alvaro Herrera wrote:
> On 2020-Sep-11, Robert Haas wrote:
>
> > On Fri, Sep 4, 2020 at 9:49 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > > I discovered a problem today while trying to do a VPATH build on
> > > a machine I don't use that often:
> > >
> > > $ make
> > > ...
> > > In file included from /home/tgl/pgsql/src/include/postgres.h:47,
> > > from /home/tgl/pgsql/src/common/hashfn.c:24:
> > > /home/tgl/pgsql/src/include/utils/elog.h:71:10: fatal error: utils/errcodes.h: No such file or directory
> > > 71 | #include "utils/errcodes.h"
> > > | ^~~~~~~~~~~~~~~~~~
> > > compilation terminated.
> >
> > I think I've seen this before, but I don't have an opinion on how to fix it.
>
> Me too. It would be useful to have a way to report that build artifacts
> are in the source dir that should be in the build dir. I don't know if
> this is in any way workable.
"git clean -nx" should list them for vpath builds.
Regards,
Andres
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-09-11 18:25:27 | Re: factorial function/phase out postfix operators? |
Previous Message | Andres Freund | 2020-09-11 18:09:30 | Re: Simplified version of read_binary_file (src/backend/utils/adt/genfile.c) |