| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [BUG v13] Crash with event trigger in extension |
| Date: | 2020-09-08 14:33:24 |
| Message-ID: | 20200908143324.GA11045@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 2020-Sep-08, Jehan-Guillaume de Rorthais wrote:
> It appears that when keeping the event trigger enabled,
> currentEventTriggerState might be initiated multiple times: one for the top
> level "alter extension ... update", then once per DDL query triggering en event
> in the extension update script. I suppose there's no crash because the very
> first currentEventTriggerState initialized at top level is overrode by next
> ones, each being destroyed in their own context. So at the end of the
> extension script, currentEventTriggerState is just destroyed and empty.
Hmm. I spent a lot of time making sure the event trigger thing worked
correctly in reentrant cases, but I don't think the case of execution of
extension scripts was ever considered. So you're right that it might be
broken, since it appears not to be thoroughly tested (if at all).
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2020-09-08 14:36:23 | Re: BUG #15285: Query used index over field with ICU collation in some cases wrongly return 0 rows |
| Previous Message | Jehan-Guillaume de Rorthais | 2020-09-08 14:15:11 | Re: [BUG v13] Crash with event trigger in extension |