| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Jose Luis Tallon <jltallon(at)adv-solutions(dot)net> |
| Subject: | Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly |
| Date: | 2020-09-02 23:07:07 |
| Message-ID: | 20200902230706.GA29760@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 03, 2020 at 12:00:17AM +0300, Alexey Kondratov wrote:
> On 2020-09-02 07:56, Justin Pryzby wrote:
> >
> > Done in the attached, which is also rebased on 1d6541666.
> >
> > And added RelationAssumeNewRelfilenode() as I mentioned - but I'm hoping
> > to
> > hear from Michael about any reason not to call
> > RelationSetNewRelfilenode()
> > instead of directly calling the things it would itself call.
>
> The latest patch set immediately got a conflict with Michael's fixup
> 01767533, so I've rebased it first of all.
On my side, I've also rearranged function parameters to make the diff more
readable. And squishes your changes into the respective patches.
Michael started a new thread about retiring ReindexStmt->concurrent, which I
guess will cause more conflicts (although I don't see why we wouldn't implement
a generic List grammar now rather than only after a preliminary patch).
--
Justin
| Attachment | Content-Type | Size |
|---|---|---|
| v25-0001-Change-REINDEX-CLUSTER-to-accept-an-option-list.patch | text/x-diff | 23.4 KB |
| v25-0002-Deprecate-ReindexStmt-concurrent-and-options.patch | text/x-diff | 16.1 KB |
| v25-0003-Allow-REINDEX-to-change-tablespace.patch | text/x-diff | 29.8 KB |
| v25-0004-Allow-CLUSTER-and-VACUUM-FULL-to-change-tablespa.patch | text/x-diff | 23.5 KB |
| v25-0005-Implement-vacuum-full-cluster-INDEX_TABLESPACE-t.patch | text/x-diff | 19.0 KB |
| v25-0006-Refactor-gram.y-in-order-to-add-a-common-parenth.patch | text/x-diff | 6.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2020-09-02 23:16:56 | Re: [NBTREE] Possible NULL pointer dereference (backend/access/nbtree/nbutils.c) |
| Previous Message | Tom Lane | 2020-09-02 22:30:12 | Re: proposal - function string_to_table |