| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: REINDEX SCHEMA/DATABASE/SYSTEM weak with dropped relations |
| Date: | 2020-09-02 02:41:48 |
| Message-ID: | 20200902024148.GB20149@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> diff --git a/src/include/nodes/parsenodes.h b/src/include/nodes/parsenodes.h
> index 47d4c07306..23840bb8e6 100644
> --- a/src/include/nodes/parsenodes.h
> +++ b/src/include/nodes/parsenodes.h
> @@ -3352,6 +3352,7 @@ typedef struct ConstraintsSetStmt
> /* Reindex options */
> #define REINDEXOPT_VERBOSE (1 << 0) /* print progress info */
> #define REINDEXOPT_REPORT_PROGRESS (1 << 1) /* report pgstat progress */
> +#define REINDEXOPT_MISSING_OK (2 << 1) /* skip missing relations */
I think you probably intended to write: 1<<2
Even though it's the same, someone is likely to be confused if they try to use
3<<1 vs 1<<3.
I noticed while resolving merge conflict.
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-09-02 02:48:06 | Re: [Patch] Optimize dropping of relation buffers using dlist |
| Previous Message | Bruce Momjian | 2020-09-02 02:27:03 | Re: "cert" + clientcert=verify-ca in pg_hba.conf? |