Re: Switch to multi-inserts for pg_depend

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: Re: Switch to multi-inserts for pg_depend
Date: 2020-08-31 07:56:06
Message-ID: 20200831075606.GE6555@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Aug 15, 2020 at 10:50:37AM +0900, Michael Paquier wrote:
> What are you suggesting here? A new API layer to manage a set of
> slots?

It has been a couple of weeks, and I am not really sure what is the
suggestion here. So I would like to move on with this patch set as
the changes are straight-forward using the existing routines for
object addresses by grouping all insert dependencies of the same type.
Are there any objections?

Attached is a rebased set, where I have added in indexing.h a unique
definition for the hard limit of 64kB for the amount of data that can
be inserted at once, based on the suggestion from Alvaro and Andres.
--
Michael

Attachment Content-Type Size
v2-0001-Use-multi-inserts-for-pg_depend.patch text/x-diff 7.5 KB
v2-0002-Switch-to-multi-insert-dependencies-for-many-code.patch text/x-diff 40.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jakub Wartak 2020-08-31 08:49:54 Re: Handing off SLRU fsyncs to the checkpointer
Previous Message Amit Kapila 2020-08-31 07:54:30 Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions