Re: [PATCH] Fix Uninitialized scalar variable (UNINIT) (src/backend/access/heap/heapam_handler.c)

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Fix Uninitialized scalar variable (UNINIT) (src/backend/access/heap/heapam_handler.c)
Date: 2020-08-25 23:18:08
Message-ID: 20200825231808.GA30348@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-Aug-25, Ranier Vilela wrote:

> 1. Even heap_get_root_tuples at line 1347, be called.
> Does it fill all roots_offsets?

Yes -- read the comments there.

> 2. hscan->rs_cbuf is constant?
> if (hscan->rs_cblock != root_blkno)

It is the buffer that contains the given block. Those two things move
in unison. See heapgettup and heapgettup_pagemode.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-08-25 23:20:18 Re: [PATCH] Fix Uninitialized scalar variable (UNINIT) (src/backend/access/heap/heapam_handler.c)
Previous Message Ranier Vilela 2020-08-25 23:15:02 Re: [PATCH] Fix Uninitialized scalar variable (UNINIT) (src/backend/access/heap/heapam_handler.c)