Re: Fix a couple of misuages of bms_num_members()

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix a couple of misuages of bms_num_members()
Date: 2020-08-25 13:18:02
Message-ID: 20200825131802.v6diaoslgcea2xe4@development
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 26, 2020 at 12:51:37AM +1200, David Rowley wrote:
>I noticed today there are a few places where we use bms_num_memebers()
>where we really should be using bms_membership(). These are not bugs,
>they're mostly just bad examples to leave laying around, at best, and
>a small performance penalty, at worst.
>
>Unless there are any objections, I plan to push this to master only in
>about 10 hours time.
>

Seems OK to me. Thanks.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2020-08-25 13:20:07 [PATCH] Resource leaks (src/backend/libpq/hba.c)
Previous Message Amit Kapila 2020-08-25 12:57:31 Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions