From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Bernd Helmle <mailings(at)oopsware(dot)de> |
Cc: | PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
Subject: | Re: Documentation patch for backup manifests in protocol.sgml |
Date: | 2020-08-21 22:03:32 |
Message-ID: | 20200821220332.GG13363@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Aug 18, 2020 at 02:41:09PM +0200, Bernd Helmle wrote:
> Hi,
>
> protocol.sgml describes the protocol messages received by a BASE_BACKUP
> streaming command, but doesn't tell anything about the additional
> CopyResponse data message containing the contents of the backup
> manifest (if requested) after having received the tar files. So i
> propose the attached to give a little more detail in this paragraph.
>
> Thanks, Bernd
>
> diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
> index 8b00235a516..31918144b37 100644
> --- a/doc/src/sgml/protocol.sgml
> +++ b/doc/src/sgml/protocol.sgml
> @@ -2665,8 +2665,10 @@ The commands accepted in replication mode are:
> <quote>ustar interchange format</quote> specified in the POSIX 1003.1-2008
> standard) dump of the tablespace contents, except that the two trailing
> blocks of zeroes specified in the standard are omitted.
> - After the tar data is complete, a final ordinary result set will be sent,
> - containing the WAL end position of the backup, in the same format as
> + After the tar data is complete, and if a backup manifest was requested,
> + another CopyResponse result is sent, containing the manifest data for the
> + current base backup. In any case, a final ordinary result set will be
> + sent, containing the WAL end position of the backup, in the same format as
> the start position.
> </para>
If someone can confirm this, I will apply it? Magnus?
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2020-08-22 00:40:48 | Re: xl_heap_header alignment? |
Previous Message | Peter Geoghegan | 2020-08-21 17:52:52 | Re: Problems with the FSM, heap fillfactor, and temporal locality |