Re: pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.

From: Noah Misch <noah(at)leadboat(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.
Date: 2020-08-15 20:48:18
Message-ID: 20200815204818.GA2082300@rfd.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sat, Aug 15, 2020 at 04:39:05PM -0400, Tom Lane wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
> > Prevent concurrent SimpleLruTruncate() for any given SLRU.
>
> I find it fairly scary that you've changed enum LockTagType in the
> back branches. Are we quite certain that no extensions have compiled-in
> values of that enum?
>
> Safer from an ABI standpoint would be to add the new value at the end,
> at least in the back branches.

Yeah, that was negligent. Several PGXN modules do refer to locktags. I'll
move it.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2020-08-15 23:17:57 pgsql: Move new LOCKTAG_DATABASE_FROZEN_IDS to end of enum LockTagType.
Previous Message Tom Lane 2020-08-15 20:39:05 Re: pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.