| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: TAP tests and symlinks on Windows |
| Date: | 2020-07-16 10:21:27 |
| Message-ID: | 20200716102028.GE8389@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 15, 2020 at 11:04:28AM -0400, Andrew Dunstan wrote:
> This is the simplest invocation I found to be reliable on msys2 (and it
> took me a long time to find). If you have a tested alternative please
> let me know.
Having a working MSYS environment is still on my TODO list :)
> I don't understand this comment. The skip statement here is in a SKIP
> block. In fact skip only works inside SKIP blocks. (perldoc Test::More
> for details). Maybe you got confused by the diff format.
Indeed, I got trapped by the diff here. Thanks.
The patch looks good to me.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2020-07-16 10:33:42 | Re: Resetting spilled txn statistics in pg_stat_replication |
| Previous Message | Christoph Berg | 2020-07-16 10:07:43 | Encoding of src/timezone/tznames/Europe.txt |