| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: some more pg_dump refactoring |
| Date: | 2020-07-09 16:56:27 |
| Message-ID: | 20200709165627.GA24091@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Jul-09, Peter Eisentraut wrote:
> On 2020-07-08 06:42, Fabien COELHO wrote:
> > > What do you think about this patch to reorganize the existing code from that
> > > old commit?
> >
> > I think it is a definite further improvement.
> >
> > Patch applies cleanly, compiles, global & pg_dump tap test ok, looks ok to
> > me.
>
> Thanks. I have committed that, and attached is my original patch adjusted
> to this newer style.
Thanks, I too prefer the style where queries are split in lines instead
of a single very long one, at least when looking at log_statement=all
lines generated by pg_dump runs. It's not a *huge* usability
improvement, but I see no reason to make things worse.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Soumyadeep Chakraborty | 2020-07-09 17:56:10 | Re: posgres 12 bug (partitioned table) |
| Previous Message | Konstantin Knizhnik | 2020-07-09 16:49:26 | Re: Postgres is not able to handle more than 4k tables!? |