From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | "movead(dot)li(at)highgo(dot)ca" <movead(dot)li(at)highgo(dot)ca> |
Cc: | robertmhaas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_resetwal --next-transaction-id may cause database failed to restart. |
Date: | 2020-07-09 05:18:35 |
Message-ID: | 20200709051835.GA8638@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2020-Jul-09, movead(dot)li(at)highgo(dot)ca wrote:
> >> ISTM that a reasonable compromise is that if you use -x (or -c, -m, -O)
> >> and the input value is outside the range supported by existing files,
> >> then it's a fatal error; unless you use --force, which turns it into
> >> just a warning.
>
> >One potential problem is that you might be using --force for some
> >other reason and end up forcing this, too. But maybe that's OK.
> Yes it's true, so I try to add a new option to control this behavior, you
> can see it in the last mail with attach.
It may be OK actually; if you're doing multiple dangerous changes, you'd
use --dry-run beforehand ... No? (It's what *I* would do, for sure.)
Which in turns suggests that it would good to ensure that --dry-run
*also* emits a warning (not an error, so that any other warnings can
also be thrown and the user gets the full picture).
I think adding multiple different --force switches makes the UI more
complex for little added value.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Khandekar | 2020-07-09 05:28:20 | Re: Auto-vectorization speeds up multiplication of large-precision numerics |
Previous Message | David G. Johnston | 2020-07-09 05:07:46 | Re: Implement UNLOGGED clause for COPY FROM |