From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | jgdr(at)dalibo(dot)com |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, robertmhaas(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, andres(at)anarazel(dot)de, masao(dot)fujii(at)oss(dot)nttdata(dot)com |
Subject: | Re: [patch] demote |
Date: | 2020-06-26 07:26:16 |
Message-ID: | 20200626.162616.1557094725705586971.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Mmm. Fat finger..
At Fri, 26 Jun 2020 16:14:38 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> Hello.
>
> If we are going to dive so close to server shutdown, we can just
> utilize the restart-after-crash path, which we can assume to work
> reliably. The attached is a quite rough sketch, hijacking smart
> shutdown path for a convenience, of that but seems working. "pg_ctl
> -m s -W stop" lets server demote.
>
> > I hadn't time to investigate Robert's concern about shared memory for snapshot
> > during recovery.
>
> The patch does all required clenaup of resources including shared
The path does all required clenaup of..
> memory, I believe. It's enough if we don't need to keep any resources
> alive?
>
> > The patch doesn't deal with prepared xact yet. Testing "start->demote->promote"
> > raise an assert if some prepared xact exist. I suppose I will rollback them
> > during demote in next patch version.
> >
> > I'm not sure how to divide this patch in multiple small independent steps. I
> > suppose I can split it like:
> >
> > 1. add demote checkpoint
> > 2. support demote: mostly postmaster, startup/xlog and checkpointer related
> > code
> > 3. cli using pg_ctl demote
> >
> > ...But I'm not sure it worth it.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2020-06-26 08:11:13 | Re: Ought to use heap_multi_insert() for pg_attribute/depend insertions? |
Previous Message | Kyotaro Horiguchi | 2020-06-26 07:14:38 | Re: [patch] demote |