Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: petermpallesen(at)gmail(dot)com, pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples
Date: 2020-06-16 17:49:04
Message-ID: 20200616174904.GC12171@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On Tue, Jun 16, 2020 at 01:39:45PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > I have developed the attached patch which is in a better direction.
>
> I still wish you wouldn't jam this topic into an only-marginally-related
> sentence. In the case at hand, the point that the existing text is
> making is that a no-op update will fire triggers. Which is not
> something that suppress_redundant_updates_trigger will suppress,
> so again it seems confusing to mention that in the same breath.
>
> I think that perhaps the right thing to do is add a new para to
> CREATE TRIGGER's "Notes" section, along the lines of
>
> There are a few built-in trigger functions that can be used
> to solve common problems without having to write your own trigger
> code. See Section 9.28.
>
> This would have the advantage of covering the other built-in triggers
> not only suppress_redundant_updates_trigger.

OK, I didn't think there was enough desire to put it its own paragraph,
but I like the idea of mentioning all of the trigger functions; patch
attached.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

Attachment Content-Type Size
trigger.diff text/x-diff 728 bytes

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Tom Lane 2020-06-16 18:02:20 Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples
Previous Message Tom Lane 2020-06-16 17:39:45 Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples