Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: petermpallesen(at)gmail(dot)com, pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples
Date: 2020-06-16 16:41:08
Message-ID: 20200616164108.GA12171@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On Tue, Jun 16, 2020 at 10:08:14AM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > I have created the attached patch to mention
> > suppress_redundant_updates_trigger() in this case. I don't think having
> > an actual example is warranted.
>
> I don't like this patch, because in fact
> suppress_redundant_updates_trigger is entirely unrelated to the stated
> purpose of that example (namely, to log something if the table was
> changed). The way you've written it makes it sound like
> suppress_redundant_updates_trigger could be used as an alternative
> implementation of that requirement.

Ah, I see your point.

> If you want to mention suppress_redundant_updates_trigger somewhere
> in this area, that's fine, but it should be treated as an independent
> topic rather than being wedged into the middle of an unrelated example.
> Maybe a distinct para saying something like "To suppress no-op updates
> of a table, see suppress_redundant_updates_trigger." (and making that
> an actual link would be a good idea).

I have developed the attached patch which is in a better direction.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

Attachment Content-Type Size
trigger.diff text/x-diff 793 bytes

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Tom Lane 2020-06-16 17:39:45 Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples
Previous Message Tom Lane 2020-06-16 14:08:14 Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples